wpilibsuite / frc-docs

Official FRC Documentation powered by Read the Docs
https://docs.wpilib.org
Other
149 stars 264 forks source link

Networking Updates #493

Closed JonathanLindsey closed 4 years ago

JonathanLindsey commented 4 years ago

I am putting together updates for the networking section. For example, as of today (1/20/2020) the Mixing Dynamic and Static Configurations section is outdated.

In the pits, a team may encounter issues with mixing Static and DHCP devices for the following reason. As mentioned above, DHCP devices will fall back to a link-local address (169.254.xx.yy) if a server isn’t present.

The robot radio now acts as a DHCP server, therefore devices will not fall back to link local in the pits unless the robot radio is disconnected.

Anyway, does anyone have more editable versions of the the drawings like this one? image Just a source for the device pictures would be great.

Daltz333 commented 4 years ago

Unfortunately the source for the images is no longer available.

benjamin-antupit commented 4 years ago

I'm working on re-doing all of the frc-docs diagrams in PR #620. I replicated the diagram currently shown on this page. Please let me know what is inaccurate and I would be happy to adjust accordingly. @JonathanLindsey @Daltz333


image

AustinShalit commented 4 years ago

Funny enough... that graphic is out of date. The robot radio now runs a DHCP server on the ethernet side of the network meaning all devices should never get a local link IP address. From https://docs.wpilib.org/en/stable/docs/networking/networking-introduction/ip-configurations.html:

benjamin-antupit commented 4 years ago

Sounds good. @AustinShalit, I thought that IP cameras and other devices will not be accessible in the pits. Is this still true?

prateekma commented 4 years ago

These devices should be accessible in the pits from the DS Laptop if you connect via the robot radio (or by using the PortForwarder class and connecting via USB).

benjamin-antupit commented 4 years ago

Thanks for the correction. How does this revision look? Screen Shot 2020-04-16 at 4 58 24 PM

AustinShalit commented 4 years ago

That looks good. What if you changed the field diagram to have a dashed line between the DS and bridge to highlight that it is not a direct connection (it really goes through a few switches and a AP).

AustinShalit commented 4 years ago

You might add a third panel that shows connection via USB.

benjamin-antupit commented 4 years ago

Good idea. I'm not sure how well this image fits in its original place here. Thoughts on placement?Anything else on the diagram? image

AustinShalit commented 4 years ago
  1. On the field - good
  2. In the pits via radio - good
  3. In the pits via USB - roboRIO gets 2 IP addresses here: the 10.TE.AM.2 on the "green" network and 172.22.11.2 on the "blue" network. Driver station does not get a 10.TE.AM.X address, it gets a 172.22.11.1 (I think, need to check). We should highlight that without a network forwarder on the rio, devices on the "green" network cannot talk to devices on the "blue" network

Might consider swapping the IP cameras for a raspberry PIs because that is what most teams use these days.

sciencewhiz commented 4 years ago

a network forwarder like https://docs.wpilib.org/en/stable/docs/networking/networking-utilities/portforwarding.html

benjamin-antupit commented 4 years ago

Sounds good. Latest revision below. I'll add a note in the article that a network forwarder is required to bridge the blue and green networks when connected via USB. image

Daltz333 commented 4 years ago

Just a small nit pick, could the inside corners not be rounded?

benjamin-antupit commented 4 years ago

As requested: image

JonathanLindsey commented 4 years ago

Thanks for redoing that diagram and all the others @yellowjaguar5.

I noticed that the Driver Station icon is broken when rendered in FireFox and Chrome. However, it is not broken when opened in the online version of diagrams.net. Do you have any idea why that would be and how to fix it? https://docs.wpilib.org/en/latest/docs/networking/networking-introduction/networking-basics.html#mixing-dynamic-and-static-configurations

benjamin-antupit commented 4 years ago

Thanks for the ping. School is just starting for me, so I have very little time for side projects. I hope to address it in the next two weeks. Future folks who stumble across this, feel free to ping me again if I don't get to it in a timely manner.

JonathanLindsey commented 4 years ago

No problem. Actually I re-exported it from app.diagrams.net and it appears to be working now. Still not sure why it happened though.

benjamin-antupit commented 4 years ago

@JonathanLindsey I created a new PR (#820) to address this issue. Can you verify that this diagram has all the icons present now?

@Daltz333 Can this issue be closed once #820 is merged?

JonathanLindsey commented 4 years ago

@yellowjaguar5 I just checked it by using the above link now that it's merged and it works. Thanks.