wpilibsuite / native-utils

Gradle utility plugin for compiling native libraries
Other
4 stars 21 forks source link

Third party library import command refers to wrong folder #146

Closed JochemvdBroek closed 1 year ago

JochemvdBroek commented 1 year ago

We are using IntelliJ to program and we ran into an issue with importing libraries. We used the command gradlew vendordep --url=FRCLOCAL/PathplannerLib.json to import the library when the json was installed in the directory :C\users\public\wpilib\**2023**\vendordeps, but the command prompt in intellij gave the error that it couldn't find the directory :C\users\public\wpilib\**frc2023**\vendordeps. The solution I came up with is to make a second folder in the wpilib folder called frc2023 with only the vendordeps in it, but it should be fixable that the command refers straight to the 2023 folder, right?

Starlight220 commented 1 year ago

Found the problem:

    private final String frcYear = "frc2023";

(https://github.com/wpilibsuite/native-utils/blob/main/src/main/java/edu/wpi/first/nativeutils/vendordeps/WPIVendorDepsExtension.java#L342-L342)

JochemvdBroek commented 1 year ago

Do I have to fix this myself or will this be a fix in a future publish?