Make deprecations produce errors in WPILib builds

wpilibsuite / native-utils

Gradle utility plugin for compiling native libraries

Other

4 stars 21 forks source link

Make deprecations produce errors in WPILib builds #169

Closed calcmogul closed 11 months ago

PeterJohnson commented 11 months ago

I thought we turned this off explicitly because in some cases there's no way to suppress the deprecation warning.

calcmogul commented 11 months ago

We've been using the WPI_IGNORE_DEPRECATED and WPI_UNIGNORE_DEPRECATED macros to suppress deprecated calls we have to make internally. allwpilib already removes the -Wno-error=deprecated-declarations flag, so this PR is just making that apply to everything that uses native-utils.

PeterJohnson commented 11 months ago

We remove it only for RoboRIO targets? https://github.com/wpilibsuite/allwpilib/blob/main/shared/config.gradle#L58-L63

calcmogul commented 11 months ago

I think that was an oversight by me. We build everything for athena, so it caught all the instances of unsuppressed deprecation warnings.