search

wpilibsuite / ntcore

NetworkTables Core Library (ARCHIVED, merged into allwpilib)
Other
39 stars 28 forks source link

Fix two bugs in client synchronization. #270

Closed PeterJohnson closed 6 years ago

PeterJohnson commented 6 years ago

Both could occur if a client and server write to the same key and the server disconnects/reconnects (or restarts).

Bug 1: the client did not properly update the sequence number in this case, so later server updates could be ignored until the sequence number wrapped.

Bug 2: the client did not properly set the id and sequence number for the update message back to the server, so the server would ignore the message.

bhjelstrom commented 6 years ago

Fixes Limelight sync issue

virtuald commented 6 years ago

I know this needs to get out ASAP, but it would be good to put in a unit test that covers this.