search

wpilibsuite / ntcore

NetworkTables Core Library (ARCHIVED, merged into allwpilib)
Other
39 stars 28 forks source link

Fix ability to compile with gcc #274

Closed rjbell4 closed 6 years ago

rjbell4 commented 6 years ago

With these changes, I am able to compile a small C program with gcc

frcjenkins commented 6 years ago

Can one of the admins verify this patch?

frcjenkins commented 6 years ago

Can one of the admins verify this patch?

frcjenkins commented 6 years ago

Can one of the admins verify this patch?

frcjenkins commented 6 years ago

Can one of the admins verify this patch?

PeterJohnson commented 6 years ago

While it works, the way the ifdef is done doesn't feel very idiomatic. I'd prefer one ifdef for the headers and a separate one for the extern "C".

rjbell4 commented 6 years ago

Sure, I was just trying to reduce the #ifdefs, since they were on the same condition. Sorry for the day; I've updated the pull request now.

PeterJohnson commented 6 years ago

Moved to wpilibsuite/allwpilib#1007 now that ntcore is merged into allwpilib.