search

wpilibsuite / shuffleboard

A modern dashboard for FRC
Other
79 stars 84 forks source link

Improper handling of deleted NTCore entries #310

Open JaciBrunning opened 6 years ago

JaciBrunning commented 6 years ago

When deleting an entry with NetworkTables (i.e. table.getEntry("myEntry").delete()), the key remains in the outline viewer (and the tab, if a widget is present).

If the widget is not present in the tab, the deleted entry that still remains in the outline viewer cannot be dragged into the tab (i.e. cannot be interacted with). Deleted entries appear to be ghosting.

bradamiller commented 6 years ago

Thanks for the report.

Just a quick question, did you notice if the OutlineViewer standalone program also has the same issue?

JaciBrunning commented 6 years ago

OutlineViewer standalone does not have this same issue

SamCarlberg commented 6 years ago

I am unable to reproduce this when deleting entries through outlineviewer. Deleting an entry through outlineviewer removes the entry from the sources view in shuffleboard.

However, deleting an entry does not delete the cached source or disable existing widgets for that source, allowing the key to be re-added by eg typing into a text field, or throwing an exception if an entry is added with the same key but a different data type