search

wpilibsuite / shuffleboard

A modern dashboard for FRC
Other
80 stars 83 forks source link

Don't switch to selected tab on value change #771

Closed Starlight220 closed 1 year ago

Starlight220 commented 1 year ago

Fixes #745

For some reason, the tab structure listeners were called also on value changes (and not just metadata changes). I've done some testing to ensure this doesn't break functionality, but I may have missed something.

Starlight220 commented 1 year ago

This has an issue with repeated calls from code to not work due to NT duplicate removal. It'll need the KeepDuplicates flag set on the robot-side publisher and possibly also the shuffleboard-side subscriber.

Starlight220 commented 1 year ago

I've extracted the tab selection to a separate listener (similar to how the tab array is separate), and now everything works correctly once the robot-code side changes in wpilibsuite/allwpilib#5198 are applied.