SamCarlberg commented 4 weeks ago

Overview

Removes various sources of high CPU usage:

The live network table preview has been removed due to the high frequency of node redraws. Spot checking data will now need to be done by dragging a data widget into a tab. Generic table data should still be displayable with the generic tree table widget. The NT source preview now displays the data type of a topic instead of its current value.
The subscribe-to-all-NT-data behavior has been changed to only subscribe to topic information. This should cut down on bandwidth and some CPU usage
The widget gallery has been removed with no replacement. Drawing the large number of dummy widgets took a surprising CPU load and occasionally caused problems at startup when third party widgets from plugins would crash

Starlight220 commented 4 weeks ago

How coupled are these changes? I think it'd be better to split it into different PRs.

SamCarlberg commented 4 weeks ago

How coupled are these changes? I think it'd be better to split it into different PRs.

The live NT preview and widget gallery changes are both resulting from profiling the JavaFX scene graph. The NT subscribe-to-all change naturally falls out of that, since there's no need to have subscriptions that are never used

wpilibsuite / shuffleboard

Puncture the bloat balloon #807

Overview