FIX: Social media twitter card tags

wpilibsuite / sphinxext-opengraph

Sphinx extension to generate unique OpenGraph metadata

https://sphinxext-opengraph.readthedocs.io

Other

74 stars 27 forks source link

FIX: Social media twitter card tags #101

Closed choldgraf closed 1 year ago

choldgraf commented 1 year ago

I caught a bug that we weren't testing for. The summary_large_image tag wasn't being properly inserted. This fixes that bug, and also adds a test for it.

choldgraf commented 1 year ago

ping - this is a bug, the cards won't really work on twitter until it is merged+released.

choldgraf commented 1 year ago

pinging @TheTripleV and @Daltz333 again. can somebody please review/merge/release? I would be happy to do this myself but I don't have the permissions on this repo/pypi.

choldgraf commented 1 year ago

Thanks <3 - I know you all likely have a million other things going on so I appreciate you taking the time to review/merge