search

wpilibsuite / sphinxext-opengraph

Sphinx extension to generate unique OpenGraph metadata
https://sphinxext-opengraph.readthedocs.io
Other
74 stars 27 forks source link

Complete Type Hints and Add support for custom tags #13

Closed TheTripleV closed 4 years ago

TheTripleV commented 4 years ago

Type hints

Type hints were only partially filled in. This completes them. This allows intellisense to work.

Custom tag support

Discourse's Onebox invented their own og tag, "og:ignore_canonical".

sciencewhiz commented 4 years ago

Will og:ignore_canonical allow the frc-docs to onebox on discourse?

TheTripleV commented 4 years ago

Yes, it should. I haven't found it documented anywhere but it's in the Onebox source code.

ItayZiv commented 4 years ago

I forgot to fully do typing when originally doing stuff, also probably worth having a config options for custom tags, not a default (not relevant for everyone using this)

TheTripleV commented 4 years ago

Based on Discord discussion:

Ex.

ogp_custom_meta_tags = [
    '<meta property="og:ignore_canonical" content="true" />',
]