search

wpilibsuite / sphinxext-opengraph

Sphinx extension to generate unique OpenGraph metadata
https://sphinxext-opengraph.readthedocs.io
Other
74 stars 27 forks source link

Use first image (after refactor) #26

Closed TheTripleV closed 3 years ago

TheTripleV commented 3 years ago

This PR is functionally the same as the description in #18 but is applied after the refactor. Could you take a look at it, @tcmetzger ?

tcmetzger commented 3 years ago

Absolutely - just give me few days!

tcmetzger commented 3 years ago

One small thing I noticed right away: in README.md, line 16, there should be quotation marks around sphinxext.opengraph (should be a list of strings).

tcmetzger commented 3 years ago

@TheTripleV Those two issues are the only two things I was able to see. Thanks for your work on this very helpful extension!

TheTripleV commented 3 years ago

I addressed the 2 issues and added a test case to cover

situation where ogp_use_first_image is enabled but no image is present