search

wpilibsuite / sphinxext-opengraph

Sphinx extension to generate unique OpenGraph metadata
https://sphinxext-opengraph.readthedocs.io
Other
74 stars 27 forks source link

Avoid printing og:description if empty #42

Closed eguidotti closed 3 years ago

eguidotti commented 3 years ago

This is a minimal PR to check if og:description is empty and avoid printing an empty tag.

TheTripleV commented 3 years ago

If this is regarding #41, description is auto-generated from the contents of each page. Unless a page is empty, bool(description) will always be true. This is a good check to have though. Thanks.

eguidotti commented 3 years ago

Nice! I guess this would also avoid printing the description when the description length is set to zero (besides empty pages). Do you already have some plans about a possible merging date? Thanks a lot!

TheTripleV commented 3 years ago

A new release has been made and published to PyPi.

eguidotti commented 3 years ago

That's great, I look forward to trying it out!