search

wpilibsuite / sphinxext-opengraph

Sphinx extension to generate unique OpenGraph metadata
https://sphinxext-opengraph.readthedocs.io
Other
74 stars 27 forks source link

fix og:url for "dirhtml" builder #54

Closed ru-fu closed 2 years ago

ru-fu commented 2 years ago

The "dirhtml" builder correctly uses ".html" as file suffix, but the file suffix should not be part of the URL. We want ".../file_name/" as URL in this case, not ".../file_name.html".

Signed-off-by: Ruth Fuchss ruth.fuchss@canonical.com

TheTripleV commented 2 years ago

Could you add a test case for this?

ru-fu commented 2 years ago

Could you add a test case for this?

Done.

ItayZiv commented 2 years ago

Make sure you run black so tests pass (black .)