Open ItayZiv opened 2 years ago
Why doesn't it work on RTD?
If you look at the og tags of the website of this extension you will see the website tag is just the page name.
I'm quite sure this is because you can't modify the config object. My bad I missed something, still need to check why this happens tho.
I want to use this opportunity to use html_baseurl
even not in RTD.'
Edit: Basically I think that we should have it set up so that html_baseurl
is used unless ogp_site_url
is set, if it is set use ogp_site_url
. If both aren't configured, raise an exception.
It seems that when I check the PR docs build (and the PR build on other PRs) it actually seems to get the correct URL (https://sphinxext-opengraph.readthedocs.io/en/latest/index.html
).
Regardless I'd still like to do the aforementioned html_baseurl
change, but not really sure why the latest docs don't work.
Actually, it seems like these are two separate matters, the docs links to https://sphinxext-opengraph.readthedocs.io/en/latest/
as the default, yet the latest
branch is not updated, while https://sphinxext-opengraph.readthedocs.io/en/stable
is updated and also has og:url
linked to https://sphinxext-opengraph.readthedocs.io/en/latest/index.html
. I split this into #57, while this issue can remain for changing the extension to use html_baseurl
outside of RTD (and refractoring the way this is currently done)
GettingWe probably want to useog:url
automatically in RTD usinghtml_baseurl
doesn't work.html_baseurl
whenogp_sire_url
isn't set regardless of if we are in an RTD environment. It might be better to recommend users to sethtml_baseurl
and only setogp_site_url
if they need it to be different than the normal canonical URL.