wpilibsuite / sphinxext-opengraph

Sphinx extension to generate unique OpenGraph metadata
https://sphinxext-opengraph.readthedocs.io
Other
74 stars 27 forks source link

Also publish sdist to PyPI #82

Closed hugovk closed 1 year ago

hugovk commented 1 year ago

This should fix https://github.com/wpilibsuite/sphinxext-opengraph/issues/81.

Before https://github.com/wpilibsuite/sphinxext-opengraph/pull/70, we built both the sdist and wheel before uploading to PyPI.

After https://github.com/wpilibsuite/sphinxext-opengraph/pull/70, we built them at the start, uploaded just the wheel as an artifact, then downloaded the wheel for testing, and downloaded the wheel for publishing to PyPI. But no sdist for publishing.

We can fix this by uploading both sdist and wheel as artifact, ensuring we only install the wheel using --only-binary=:all:, and then for PyPI publishing we also have both files.

(Another way would be to rebuild both in the pypi-release instead of using the artifact.)