search

wpilibsuite / styleguide

Style guides for wpilibsuite projects
Other
5 stars 16 forks source link

Incorrect include what you use warnings with ifdefs #291

Open spacey-sooty opened 1 week ago

spacey-sooty commented 1 week ago

Steps to reproduce:

  1. clone this repo https://github.com/spacey-sooty/wpiformat-ifdef-repro
  2. run wpiformat
  3. see error about include memory for std::make_unique This error is incorrect as memory is included in the path where make_unique is used.
calcmogul commented 1 week ago

We use https://github.com/cpplint/cpplint/ for that, so that's a better place to open the issue.