Add export checking to windows libraries

wpilibsuite / vendor-json-repo

WPILib Vendor JSON Repository

4 stars 7 forks source link

Add export checking to windows libraries #2

Open PeterJohnson opened 5 years ago

PeterJohnson commented 5 years ago

Linux libraries are checked for exports of frc:: symbols, but Windows ones are currently not.

jasondaming commented 4 days ago

What is the risk here?

PeterJohnson commented 3 days ago

That the vendor built the Windows libraries such that they statically linked or otherwise override WPILib symbols, which could result in overriding of WPILib behavior/classes and difficult to diagnose issues due to that.