search

wplemon / gridd

Flexible grid-based WordPress theme
Other
39 stars 7 forks source link

customizer: Header color not seen #189

Closed paaljoachim closed 4 years ago

paaljoachim commented 4 years ago

I am experimenting with adding the newest Gridd development theme to a new local site for easywebdesigntutorials.com.

In the customizer I turned on Override Options then set the header background color. The header color is not seen, so it seems there is something I am missing... Screen Shot 2020-05-22 at 00 54 53

I then set the footer background color. That showed up. Screen Shot 2020-05-22 at 00 55 28

aristath commented 4 years ago

The Inheritace goes like this: Global -> Header -> Branding If the branding and navigation parts don't override, then the header-background will be shown. My guess is simply that they get overriden in the parts (branding & navigation) themselves

paaljoachim commented 4 years ago

Should inheritance by default be turned on? As it would right away leave the door open for Global options.

Going to Theme Options -> going through the main options in this list. Main Grid Layout Header Grid Footer Grid Typography

Content - Override Options Header - Override Options
Footer - Override Options Breadcrumbs - Override Options Navigation1 - Override Options

What is missing from the above is the Branding area.

One more thing. I added Navigation 2 and Navigation 3 to use the same menu as in Navigation 1 just to see where they showed up in the customizer. As I did kinda expect Nav 2 to show up directly below Nav 1. I also expected Nav 3 to show up in the footer.

aristath commented 4 years ago

On a new installation they do inherit, the default value for all the inherit/override switches in to inherit. I just tested it on a new installation and can confirm it is the case. However, if there was installed a previous version of the theme on that site, then on update the settings are set to override when the migration script runs, so that any custom color options can be applied.

paaljoachim commented 4 years ago

Hmm strange. I just built a new local dev site 2 to 3 days ago using the latest development version of Gridd and even though I override the Header I am not seeing the orange color I added. Hmm I might just need to build another local site testing it again.

I am on Chrome. Using WP 5.4 and the newest Gutenberg plugin.

paaljoachim commented 4 years ago

Aha! I activated the parent Gridd dev theme and Header Override works there, but using a child theme with just some very few modifications the Header Override is not working. Here is the child theme I am using: https://www.dropbox.com/s/rsc5q07rjxbht4u/gridd-child.zip?dl=0

paaljoachim commented 4 years ago

I updated to version 3.0. Checked to see the header override color in place. Then switched to the child theme. I did not notice the orange color. Here is an inspect on the frontend.

Header is not showing orange color override. Screen Shot 2020-05-24 at 13 51 58

Comparing with Footer: Screen Shot 2020-05-24 at 13 55 22

Navigation1, Breadcrumbs, content and footer all show the override color. It is only the Header which is not doing so.

paaljoachim commented 4 years ago

Alrighty. As I could affect all the various areas in the same section I wondered where Branding was located. It was then moved to Site Identity section.