wpoa / JATS-to-Mediawiki

A PubMed Central to MediaWiki converter
4 stars 1 forks source link

Displaying journal name in {{Citation}} on Wikisource #27

Open Daniel-Mietchen opened 10 years ago

Daniel-Mietchen commented 10 years ago

seems to work only if

| issue

is set.

Details via https://en.wikisource.org/wiki/Template:Citation .

Daniel-Mietchen commented 10 years ago

This should be fixed before or during the Wikimania Hackathon: https://github.com/wpoa/OA-signalling/issues/101 .

wrought commented 10 years ago

Can you link to an example article so I can reproduce it?

According to the template code, this should not be an issue at all.

It's possible some of this variable behavior is a result of the template breaking in other ways, which makes a result that seems to be caused by something else.

Daniel-Mietchen commented 10 years ago

Some example articles where journal names are missing in the references: https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1098/rstb.2011.0091 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1155/S1110724304404033 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1186/1475-2875-11-95 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1186/1745-6150-1-19 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1186/cc2183 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1371/journal.ppat.1001283 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1371/journal.pone.0103004 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1371/journal.pmed.1000290 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1371/journal.pbio.0020207 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.3389/fpsyt.2013.00129 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.3897/BDJ.2.e1161 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.3897/zookeys.324.5827 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.7554/eLife.00961

Seems to work fine in two of the most recent uploads, though: https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1186/1742-4690-2-11 https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/10.1371/journal.pone.0001128

wrought commented 10 years ago

Based on a sample of the "problem articles" you listed, it seems that the work field is being used:

| work = PLoS Pathog.

rather than (as in the correct two articles at the end) the journal field:

| journal = J Theor Biol

equivalently, one can use the fields periodical, journal, newspaper, or magazine for the same feature.

Klortho commented 10 years ago

I haven't checked all of Daniel's samples, but it is working for the first one, see my sandbox User:Klortho/PMC3146776.

I suppose I should check at least one more before closing this issue.