Superfluous brackets in citations after import to Wikisource

[Daniel-Mietchen]

See current version of https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/The_Vpr_protein_from_HIV-1:_distinct_roles_along_the_viral_life_cycle .

[wrought]

note, these brackets wrap the in-line <ref> tags.

Also, there are extra unnecessary comma characters inserted between each <ref></ref> node

[wrought]

[edited by klortho] Known issue: https://github.com/Klortho/JATS-to-Mediawiki/issues/12

[Klortho]

This should be fixed, see my comments at https://github.com/Klortho/JATS-to-Mediawiki/issues/12, but I haven't tested it.

[Daniel-Mietchen]

Putting on the agenda (#74) for today's meeting.

[Daniel-Mietchen]

Looks like not being fixed yet - see, e.g. "[[6],[18]-[19]." in https://en.wikisource.org/w/index.php?title=Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/The_Vpr_protein_from_HIV-1:_distinct_roles_along_the_viral_life_cycle&oldid=4921201#Structure_of_the_HIV-1_Vpr_protein

[Klortho]

Sorry, I will take a look

[Klortho]

Should be done (again) now. I left this open, but reassigned to you, Daniel, in case you want to test it before closing. I looked at the output of the XSLT, of course, but didn't try re-importing it into a wiki.

[notconfusing]

To test, I have to update the jats converter of recitation-bot. Shall I do that? Is this on master?

Max Klein ‽ http://notconfusing.com/

On Tue, Jul 29, 2014 at 5:22 AM, Chris Maloney notifications@github.com wrote:

Should be done (again) now. I left this open, but reassigned to you, Daniel, in case you want to test it before closing. I looked at the output of the XSLT, of course, but didn't try re-importing it into a wiki.

— Reply to this email directly or view it on GitHub https://github.com/wpoa/OA-signalling/issues/63#issuecomment-50430456.

[Daniel-Mietchen]

Yes, please update. It's on master: https://github.com/wpoa/JATS-to-Mediawiki/commit/edf2237e195d397d36be0430a6ba930f20ee397c .

[notconfusing]

done

From github.com:wpoa/JATS-to-Mediawiki
 * branch            master     -> FETCH_HEAD
Updating 842e360..edf2237
Fast-forward
 jats-to-mediawiki.py  |    5 ++++-
 jats-to-mediawiki.xsl |   24 ++++++++++++++++++------
 2 files changed, 22 insertions(+), 7 deletions(-)

Max Klein ‽ http://notconfusing.com/

On Wed, Jul 30, 2014 at 12:19 PM, Daniel Mietchen notifications@github.com wrote:

Yes, please update. It's on master: wpoa/JATS-to-Mediawiki@edf2237 https://github.com/wpoa/JATS-to-Mediawiki/commit/edf2237e195d397d36be0430a6ba930f20ee397c .

— Reply to this email directly or view it on GitHub https://github.com/wpoa/OA-signalling/issues/63#issuecomment-50597479.

[Daniel-Mietchen]

Looks like fixed in https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/The_Vpr_protein_from_HIV-1_distinct_roles_along_the_viral_life_cycle . Closing again. Thanks.

[Klortho]

Great!