Update oa-put: Use ogg extension instead of ogv

maflcko commented 8 years ago

There are some false positives for video. Those audio files should then not be uploaded with the ogv extension. The ogg extension is more general.

This commit is a work around, not a proper fix but I don't have the time right now to look into #142 and #119. So this at least fixes the issue in the short term.

Also this is untested.

maflcko commented 8 years ago

Motivation is to reduce the clean up work like https://commons.wikimedia.org/w/index.php?title=File%3AWhen-In-Your-Face-Is-Not-Out-of-Place-The-Effect-of-Timing-of-Disclosure-of-a-Same-Sex-Dating-pone.0135023.s004.oga&type=revision&diff=172636480&oldid=172105253

erlehmann commented 8 years ago

I think this does not fix the issue. According to RFC 5334, section 10.3, “.ogg” serves as the file extension for files that have the MIME type audio/ogg: “In particular, .ogg is used for Ogg files that contain only a Vorbis bitstream”.

https://tools.ietf.org/html/rfc5334#section-10.3

MarcoFalke notifications@github.com writes:

There are some false positives for video. Those audio files should then not be uploaded with the ogv extension. The ogg extension is more general.

This commit is a work around, not a proper fix but I don't have the time right now to look into #142 and #119. So this at least fixes the issue in the short term.

Also this is untested. You can view, comment on, or merge this pull request online at:

https://github.com/wpoa/open-access-media-importer/pull/144

-- Commit Summary --

Update oa-put

-- File Changes --
M oa-put (2)
-- Patch Links --

https://github.com/wpoa/open-access-media-importer/pull/144.patch https://github.com/wpoa/open-access-media-importer/pull/144.diff

Reply to this email directly or view it on GitHub: https://github.com/wpoa/open-access-media-importer/pull/144

Nils Dagsson Moskopp // erlehmann http://dieweltistgarnichtso.net

wpoa / open-access-media-importer

Update oa-put: Use ogg extension instead of ogv #144