search

wpoa / recitation-bot

MediaWiki bot to upload content to Wikimedia projects and update corresponding citations on Wikipedia.
GNU General Public License v3.0
9 stars 3 forks source link

Allow for TIF, TIFF, JPEG and SVG uploads #27

Closed Daniel-Mietchen closed 10 years ago

Daniel-Mietchen commented 10 years ago

Currently, only .jpg and .png are uploaded, but spelling variants thereof (e.g. .JPEG and .PNG) should also be allowed, as should TIF/ TIFF and SVG. https://github.com/wpoa/recitation-bot/blob/master/recitation-bot/journal_article.py#L167

notconfusing commented 10 years ago

i haven't seen anything coming out of pubmed that isn't like this. but i can generalize it anyway.

notconfusing commented 10 years ago

@Daniel-Mietchen can you find a test case for this, so that i haven something to test the new code on?

notconfusing commented 10 years ago

ok, i updated in this commit https://github.com/wpoa/recitation-bot/commit/8dc7235260d6eb9f281e1eefc14860c7dea250aa#diff-93ea4280f2ffb775cf90b9181f91931b

and tested, but hard to find images that dont use jpg

https://en.wikisource.org/wiki/Wikisource:WikiProject_Open_Access/Programmatic_import_from_PubMed_Central/Radiological_Diagnosis_of_Congenital_Diaphragmatic_Hernia_in_17th_Century_Korean_Mummy

notconfusing commented 10 years ago

actually there were .tifs in that Korean mummy article, but they were in supplementary information i believe.

notconfusing commented 10 years ago

this should be handled, the problem is now to incorporate supplementary files