wpoa / recitation-bot

MediaWiki bot to upload content to Wikimedia projects and update corresponding citations on Wikipedia.
GNU General Public License v3.0
9 stars 3 forks source link

Fix incomplete metadata on Commons #62

Open Daniel-Mietchen opened 7 years ago

Daniel-Mietchen commented 7 years ago

The bot's latest uploads to Commons are missing basically all the metadata. Compare https://commons.wikimedia.org/wiki/File:Amphibians-and-reptiles-of-the-state-of-Coahuila-Mexico-with-comparison-with-adjoining-states-zookeys-593-117-g003.jpg (correct) with https://commons.wikimedia.org/wiki/File:Zika-Virus-Emergence-in-Mosquitoes-in-Southeastern-Senegal-2011-pone.0109442.g001.jpg (which misses categories as well as the bot's template).

This needs immediate fixing, otherwise we cannot upload anything further, since uploads with such incomplete metadata are not acceptable on Commons.

difranco commented 7 years ago

Adding Terry, since metadata is extracted by xslt transform.

Daniel-Mietchen commented 7 years ago

My guess is that this is rather on the Python end, since this part has worked basically from the start, as it was largely copied over from https://github.com/wpoa/open-access-media-importer , which still produces decent metadata, as can be seen from the most recent uploads at https://commons.wikimedia.org/wiki/Special:ListFiles/Open_Access_Media_Importer_Bot .

Daniel-Mietchen commented 7 years ago

Interestingly, the metadata seems to be complete in the upload that misses the "File" prefix, as per #63. Examples:

difranco commented 7 years ago

That may be because I updated Terry's xslt code between then and now.

On Sat, Feb 18, 2017 at 4:59 PM Daniel Mietchen notifications@github.com wrote:

Interestingly, the metadata seems to be complete in the upload that misses the "File" prefix, as per #63 https://github.com/wpoa/recitation-bot/issues/63. Examples:

- https://commons.wikimedia.org/wiki/A-Cost-Effectiveness-Tool-for-Informing-Policies-on-Zika-Virus-Control-pntd.0004743.g001.jpg

https://commons.wikimedia.org/wiki/File:A-Cost-Effectiveness-Tool-for-Informing-Policies-on-Zika-Virus-Control-pntd.0004743.g001.jpg

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/wpoa/recitation-bot/issues/62#issuecomment-280886981, or mute the thread https://github.com/notifications/unsubscribe-auth/AAKw7dz-euwKhFFXfkiaeuAhI-64goexks5rd5P6gaJpZM4MFTBL .

Daniel-Mietchen commented 7 years ago

OK, will check some other cases.

Daniel-Mietchen commented 7 years ago

No, same picture for cases when both versions came in today:

difranco commented 7 years ago

Likely the same problem as #63

Daniel-Mietchen commented 7 years ago

Blocks #66.