Open alexmigf opened 1 month ago
@dwalkerpriv fixed
@MohamadNateqi I'm not seeing a <p>
there inside the list.
@alexmigf Sorry the second image was wrong. This is the correct one:
That image was for the time the mpdf plugin was activated.
@MohamadNateqi I'm not seeing any <p>
tag currently:
Also, mPDF extension has some code to remove the <p>
tags here: https://github.com/wpovernight/woocommerce-pdf-ips-mpdf/blob/c407b52aad1c854b563c20f086c561d8d49df84d/wcpdf-mpdf.php#L128-L134
@alexmigf What if you deactivate the mPDF plugin?
@MohamadNateqi that's the case, fixed.
@alexmigf Looks good now.
Can you also fix the difference in the indentation?
@MohamadNateqi fixed, also in mPDF extension too.
@alexmigf when I switch to this PR and have IPS Pro active, the multilingual settings disappear from the 'Pro' tab.
In the picture below, I cannot scroll down further.
@dpeyou I have updated the branch and I don't have any issues on that regard.
@alexmigf what is this supposed to change? I have tested it on other branches as well for both free plugins. Is it still supposed to be relevant with this PR?
But it appears that the text is wrongly placed on the document
@dpeyou did you change the template to "Simple RTL"?:
@YordanSoares @alexmigf that template (Simple RTL) does not appear for me. I was under the impression that this setting was supposed to achieve that: https://github.com/wpovernight/woocommerce-pdf-invoices-packing-slips/pull/810#issuecomment-2196477234
@YordanSoares I'm having the same issue as Darren, but even with lower versions of mPDF I can't get the Arabic font work. How did you tested it?
closes #773
This PR aims to achieve full mPDF compatibility for the Simple template, ultimately eliminating the need for mPDF templates altogether. If successful, we can extend this approach to the Premium Templates as well.
Requires this PR branch for testing: https://github.com/wpovernight/woocommerce-pdf-ips-mpdf/pull/21