wpovernight / woocommerce-pdf-invoices-packing-slips

Create, print & automatically email PDF invoices & packing slips for WooCommerce orders.
https://wordpress.org/plugins/woocommerce-pdf-invoices-packing-slips/
Other
99 stars 45 forks source link

New: adds full compatibility with mPDF to the Simple Template #810

Open alexmigf opened 1 month ago

alexmigf commented 1 month ago

closes #773

This PR aims to achieve full mPDF compatibility for the Simple template, ultimately eliminating the need for mPDF templates altogether. If successful, we can extend this approach to the Premium Templates as well.

Requires this PR branch for testing: https://github.com/wpovernight/woocommerce-pdf-ips-mpdf/pull/21

alexmigf commented 1 month ago

@dwalkerpriv fixed

alexmigf commented 1 month ago

@MohamadNateqi I'm not seeing a <p> there inside the list.

MohamadNateqi commented 1 month ago

@alexmigf Sorry the second image was wrong. This is the correct one:

image

That image was for the time the mpdf plugin was activated.

alexmigf commented 1 month ago

@MohamadNateqi I'm not seeing any <p> tag currently:

Screenshot from 2024-06-05 09-39-35

Also, mPDF extension has some code to remove the <p> tags here: https://github.com/wpovernight/woocommerce-pdf-ips-mpdf/blob/c407b52aad1c854b563c20f086c561d8d49df84d/wcpdf-mpdf.php#L128-L134

MohamadNateqi commented 1 month ago

@alexmigf What if you deactivate the mPDF plugin?

alexmigf commented 1 month ago

@MohamadNateqi that's the case, fixed.

MohamadNateqi commented 1 month ago

@alexmigf Looks good now.

Can you also fix the difference in the indentation?

image

alexmigf commented 1 month ago

@MohamadNateqi fixed, also in mPDF extension too.

dpeyou commented 1 week ago

@alexmigf when I switch to this PR and have IPS Pro active, the multilingual settings disappear from the 'Pro' tab.

In the picture below, I cannot scroll down further. 2024-06-28_03-23

alexmigf commented 1 week ago

@dpeyou I have updated the branch and I don't have any issues on that regard.

dpeyou commented 1 week ago

@alexmigf this has been resolved :heavy_check_mark:

dpeyou commented 1 week ago

@alexmigf what is this supposed to change? I have tested it on other branches as well for both free plugins. Is it still supposed to be relevant with this PR?

enable rtl support - wcpdf

YordanSoares commented 1 week ago

But it appears that the text is wrongly placed on the document

@dpeyou did you change the template to "Simple RTL"?:

image

dpeyou commented 1 week ago

@YordanSoares @alexmigf that template (Simple RTL) does not appear for me. I was under the impression that this setting was supposed to achieve that: https://github.com/wpovernight/woocommerce-pdf-invoices-packing-slips/pull/810#issuecomment-2196477234

dpeyou commented 1 week ago

2024-06-30_23-09_1 2024-06-30_23-09

dpeyou commented 1 week ago

screen-recording(13).webm

alexmigf commented 1 week ago

@YordanSoares I'm having the same issue as Darren, but even with lower versions of mPDF I can't get the Arabic font work. How did you tested it?