wpovernight / woocommerce-pdf-invoices-packing-slips

Create, print & automatically email PDF invoices & packing slips for WooCommerce orders.
https://wordpress.org/plugins/woocommerce-pdf-invoices-packing-slips/
Other
99 stars 45 forks source link

Tweak: improved header logo loading #826

Open alexmigf opened 2 weeks ago

alexmigf commented 2 weeks ago

Adds a new setting under Advanced > General:

Screenshot from 2024-06-27 15-14-39

alexmigf commented 1 week ago

Now I have included a new setting for "Embed images", you must test with and without it.

dwalkerpriv commented 1 week ago

Has worked for me in combination with the PT branch here, with the setting on or off.

No errors with the thumbnail block. PDF sizes aren't increased

JPEGs, PNGs and SVGs work just the same in exports and email attachments

dpeyou commented 1 week ago

I have tested with and without the "Embed Images" option, but I am not too sure what I am testing. :grin: I did not notice a change in filesize for a certain PDF I was regenerating. I have "Test mode" active.

alexmigf commented 1 week ago

@dpeyou I can't replicate your issue.

dpeyou commented 1 week ago

@alexmigf the error can be observed here:

https://tstwpdt.flywheelsites.com/wp-admin test test_THIS_test

Remember the Plugin File Editor's new location: Tools > Plugin Fie Editor

alexmigf commented 1 week ago

@dpeyou the issue is fixed now in the Pro multilingual PR.

dpeyou commented 1 week ago

@alexmigf the fatal error is gone when testing with IPS Pro #397 :heavy_check_mark:

MohamadNateqi commented 6 days ago
PHP Notice:  Undefined variable: attachment in C:\laragon\www\mohamad\wp-content\plugins\woocommerce-pdf-invoices-packing-slips\includes\documents\abstract-wcpdf-order-document.php on line 876
alexmigf commented 6 days ago

@MohamadNateqi fixed!