search

wpreadme2markdown / wp-readme-to-markdown

Convert WordPress Plugin Readme Files to GitHub Flavored Markdown
MIT License
92 stars 20 forks source link

400 Bad Request : Error When Fetching Screenshots #26

Closed varunsridharan closed 5 years ago

varunsridharan commented 5 years ago

When i run this script i just keep getting [missing image] in my readme.md so i digg deep and found i keep getting 400 Bad Request error i feel like the url validation should be done using Curl instead of fsock

sunchaserinfo commented 5 years ago

fsockopen is a standard function and curl is an external component so it's strongly preferable to fix the socket. Also I cannot reproduce your issue

varunsridharan commented 5 years ago

@sunchaserinfo i used this readme https://plugins.svn.wordpress.org/sku-shortlink-for-woocommerce/trunk/readme.txt And i tested in my local i still get 400 Bad Request

varunsridharan commented 5 years ago

Code : image

Response : image

varunsridharan commented 5 years ago

Some how it worked again. sorry i am closing this issue now.

varunsridharan commented 5 years ago

@sunchaserinfo FIY : i have the domain wpreadme2markdown.com if u want i can map ns / cname for the web version

sunchaserinfo commented 5 years ago

@varunsridharan I see you messed up with quotes in your 'fork'. We cannot support forks sorry :D

sunchaserinfo commented 5 years ago

@varunsridharan We cannot have https on custom domains on the free Heroku plan so I think that domain is a waste of money here. You can add a http redirect to https://wpreadme2markdown.herokuapp.com/ however if you want