wprig / wprig

A progressive theme development rig for WordPress.
https://wprig.io
GNU General Public License v3.0
1.27k stars 281 forks source link

Don't style classes used for structured data #86

Closed benoitchantre closed 5 years ago

benoitchantre commented 6 years ago

Classes used for structured data should not be part of the stylesheet. Having structured data or not should not have an influence on the appearance of the site.

Related issues from Underscores:

mor10 commented 6 years ago

Good issue. Are you interested in contributing with a PR, or highlight which rules you'd like to see changed?

benoitchantre commented 6 years ago

Yes. I’ll either add some comments or work on a PR next week.

benoitchantre commented 6 years ago

I'll try to work on it this week.

benoitchantre commented 5 years ago

At the moment, WP Rig has styles on the following classes related to microformats:

The only class not added by WP Rig is hentry (added by post_class()).

I would like to see styles removed from hentry, entry-title, entry-content and entry-summary. This involves to add new classnames as replacements where entry-title, entry-content and entry-summary are used in the templates. These new classnames may depend on #109.

miklb commented 5 years ago

I wouldn’t remove the microformat classes, just add new styling hooks

benoitchantre commented 5 years ago

At the moment, the idea is not to remove the microformat classes, only to move styles to other classes in order to decouple the microformat classnames and the styles. In a second step, structured data could be added with JSON-LD (recommended by Google) instead of microformats.

miklb commented 5 years ago

Ah, ok, I misread your comment regarding changing the class names. Also json-ld != microformat and I would argue not removing microformats if you want to add JSON-LD