wpscanteam / wpscan

WPScan WordPress security scanner. Written for security professionals and blog maintainers to test the security of their WordPress websites. Contact us via contact@wpscan.com
https://wpscan.com/wordpress-cli-scanner
Other
8.49k stars 1.25k forks source link

WPScan 2.5 release #682

Closed pvdl closed 9 years ago

pvdl commented 10 years ago

Good moment to release a new version of WPScan. Because: WordPress 4.0, BruCON 2014 is near.

Maybe @ethicalhack3r likes to make some preps before releasing due to the db change. Let us know! E.g. (I found that wpstools --stats is 'broken': [ERROR] nil can't be coerced into Fixnum)

To do List:

Pre release activities (25th September 12:00)

Freeze period

Release 2.5 (26 September +/- 12:00)

Afterwards

ethicalhack3r commented 10 years ago

:+1:

Release same day as WPVULNDB?

pvdl commented 10 years ago

@ethicalhack3r, do you have a date in mind?

ethicalhack3r commented 10 years ago

Will find out what day the talk is on, will email some people at BruCON.

Will be 25th or 26th I think

erwanlr commented 10 years ago

The error in the --stats is caused by something unexpected in the theme_vulns.json:

{"dailydeal":{"vulnerabilities":[]}}

That should not be in the json :D

ethicalhack3r commented 10 years ago

@erwanlr huh, I will have to look into that

@pvdl Friday 26th September

What do you think of Arachni style license for next release to prevent people commercialising WPScan? - http://www.arachni-scanner.com/license/

firefart commented 10 years ago

:+1: for the updated license. When we switch over to the new DB, we should also update the license to reflect the commercial use.

erwanlr commented 10 years ago

Does github provide a way to have the checksum of a raw file ?

I was thinking to implement the download of the data files with the --update option when the wpscan install does not contain git (i.e for Kali users)

ethicalhack3r commented 10 years ago

The Github API does provide a sha1 hash but i'm not sure if it's the sha1 hash of the actual file - https://developer.github.com/v3/repos/contents/#get-contents

erwanlr commented 10 years ago

Doesn't seem to be the sha1 of the file :(

firefart commented 10 years ago

If we add the database to a seperate GitHub Repo (as discussed before, using submodules), you yould use the latest commit hash of the repo.

ethicalhack3r commented 10 years ago

@FireFart moved repo to https://github.com/wpscanteam/vulndb

Data there currently contains some test data, will update with correct data soon

ethicalhack3r commented 10 years ago

Updated with latest data from this repo

firefart commented 10 years ago

I could set up a seperate branch on wpscan and add the database to it if you like

ethicalhack3r commented 10 years ago

I'm not sure that the API can push to a branch and if the wpvulndb user can be restricted to one. Could submodules work with the https://github.com/wpscanteam/vulndb repo?

firefart commented 10 years ago

I will add a sample to the branch, hang on and you will see :)

firefart commented 10 years ago

@ethicalhack3r https://github.com/wpscanteam/wpscan/tree/submodule

firefart commented 10 years ago

the other files like wp_version.xml and so on need to be added to the new vulndb repo to get this working correctly

firefart commented 10 years ago

another idea would be to provide the database as a GEM and update the gem via travis and a commit hook (or another build system)

ethicalhack3r commented 10 years ago

Ah! cool!

Do all files in /data need moving to vulndb repo?

firefart commented 10 years ago

jeah i currently used the data/ as a submodule, so the other files would need to go there as well

Workflow would be: -) Push changes to wpvulndb repo -) Update db reference to latest commit hash in wpscan repo

On development installations you need to: git clone .... git submodule init git submodule update

a git pull will not update your submodule, so that's a manual step.

But maybe we can enforce the --update switch this way

ethicalhack3r commented 10 years ago

How is this bit done? "Update db reference to latest commit hash in wpscan repo"

firefart commented 10 years ago

http://stackoverflow.com/a/8191413

ethicalhack3r commented 10 years ago

Not sure if that can be done via the API :-/

Might have to just do everything from CLI on the web server (automated)

firefart commented 10 years ago

hm maybe we can file a bug on the github_api gem if a submodule updating can be implemented?

erwanlr commented 10 years ago

@FireFart :

<_Phy_> ethicalhack3r, does the submodule thing will work in Kali ?
<ethicalhack3r> _Phy_ not sure, I don’t see why not, even if it doesn’t it shouldn’t be an issue if we “pre-seed” wpscan with the current databases
<ethicalhack3r> on every release we update the wpscan repo with the latest database, to update before a release can use the —update command
<_Phy_> not sure to correctly understand :D, the point of the DB is to be able to provide updates w/o having to update the wpscan code, right ?
<_Phy_> so, in Kali, if I do a --update, I would expect the DB to be updated
<_Phy_> w/o having to update to wpscan 2.4.2 for example
<_Phy_> 'Do all files in /data need moving to vulndb repo?' -> yea, would be better I think :)
<ethicalhack3r> _Phy_: yea, you’re right, I’m not sure if submodule would work in Kali
<_Phy_> and even if it works, the submodule is linked to a specific commit of the db repo, so it would require to update wpscan anyway ? :/
<ethicalhack3r> hmmm… good point...
<ethicalhack3r> we need FireFart for clarification :)
ethicalhack3r commented 10 years ago

Instead of submodules can WPScan not just grab the raw file?

erwanlr commented 10 years ago

See IRC :p

n0task commented 10 years ago

I recommend when brute force the password, first crack the same password as Username. eg: user:lovecat password:lovecat

most people use password looks like username :)

pvdl commented 10 years ago

@n0task, Please make a new issue of this request. Personally, I like the idea

pvdl commented 9 years ago

Updated To do list

ethicalhack3r commented 9 years ago

wpstools.rb -s should be fixed when using latest database files from https://github.com/wpscanteam/vulndb. Issue was data parsed from XML didn't lowercase the theme names. All old theme & plugin names now lowercased.

pvdl commented 9 years ago

checked: wpstools.rb -s works fine now.

ethicalhack3r commented 9 years ago

Created a vdb_intergration branch which outputs a link to the new DB within the references output. Please merge before release and change "CHANGE_ME_BEFORE_MERGE" string to the actual vdb URL.

I've added the TODOs in pvdl's first comment.

pvdl commented 9 years ago

@wpscanteam/owners Can someone do the Pre release activities (25th September 12:00)?

erwanlr commented 9 years ago

2 of the 4 tasks done

erwanlr commented 9 years ago

vdb_intergration merge will be done tomorrow morning

ethicalhack3r commented 9 years ago

vdb_intergration done

pvdl commented 9 years ago

Will do changelog task now.

pvdl commented 9 years ago

Ok we can: Tag / Commit / Release

erwanlr commented 9 years ago

tagged

ethicalhack3r commented 9 years ago

https://bugs.kali.org/view.php?id=1746