wpseek / wpseek-web

This repository is currently only used for issue tracking for wpseek.com
https://wpseek.com/
1 stars 0 forks source link

Plugin Doctor result is letter instead of number #14

Closed joyously closed 10 years ago

joyously commented 10 years ago

I loaded a theme zip file to Plugin Doctor desktop version and it gave me the result: Requires at least: M

It listed one deprecated function, and all the functions on the right, but I have to go look at each one to find the version information. The M could be from one file which listed: get_post_format 3 get_template_part 3 have_posts 1 is_sticky 2 the_post 1 Unknown version information Missing version information

joyously commented 10 years ago

I narrowed it down. The function get_current_user_id has a version number of MU, so that messes up everything after it. Also, function add_theme_page says N/A.

oliverschloebe commented 10 years ago

Hi joyously!

The issue was caused by #13 and has been fixed.

Thanks!

joyously commented 10 years ago

The fix for #13 certainly helped! I now get a number for the same zip file, and each function is showing a version number instead of an integer.

However, the end result number is not necessarily correct because the version number of MU still affects what comes after it. See attached screenshot and note the functions after the MU don't have a number. capture619-plugin doctor - wpseek_bug

oliverschloebe commented 10 years ago

Hey joyously, that's intentional. See the subheadings. :) Some functions don't have version information in their doc blocks, so I'm listing them under separate subheadings to clearify that version info are missing.

Image

joyously commented 10 years ago

Wow, you should change how you present the information. I had no idea those were headings. They looked like warning messages you output as you went. Maybe it's because the first section doesn't have a header of that same size and also because you put out the header even if there's nothing under it. Maybe the Missing and Unknown should go on the left with the Deprecated.

oliverschloebe commented 10 years ago

You have probably guessed that I'm not a designer by now. :D But you're right. The headings might get lost there.

oliverschloebe commented 10 years ago

Changed the layout of the "Function Breakdown" a little which should make the headings more obvious.

joyously commented 10 years ago

Looks much better.