wpseek / wpseek-web

This repository is currently only used for issue tracking for wpseek.com
https://wpseek.com/
1 stars 0 forks source link

WordPress "compat functions" #18

Closed tillkruss closed 9 years ago

tillkruss commented 10 years ago

Some of the WordPress "compat functions" are available:

But some of them aren't:

And some are incomplete:

I'd recommend removing all WordPress compatibility functions from the API.

oliverschloebe commented 10 years ago

Well, I'm not sure if completely removing all WordPress compatibility functions from wpseek.com is the right decision. E.g. hash_equals was added in PHP 5.6, but WordPress' PHP requirement is 5.2.5 so plugins and themes might still need/use this and other WordPress compatibility functions.

tillkruss commented 10 years ago

I agree that hash_equals() should stay, but hash_hmac() could be removed entirely, since it's incomplete, anyhow.

oliverschloebe commented 10 years ago

I agree. hash_hmac() will be removed after the next update cycle on wpseek.com.