Closed kristineds closed 8 years ago
@jaswsinc @raamdev This PR is ready for review. :) If you prefer to use a different Dashicon, just let me know.
By the way, the ready for review
Label tag and some other tags are not available on this repo yet.
@kristineds Looks great to me. :-) Do you want to try finishing the rest of the process for this PR?
000000-dev
For the merge steps, you can follow the instructions that GitHub has where it says "command line instructions":
Content moved to original Github issue. See Issue #1.
@raamdev Would you mind checking if I did this right? 😃 Thanks in advance.
@kristineds Looks great to me! Only one small thing: Please post the changelog entry on the original GitHub issue (https://github.com/websharks/alert-box-shortcode/issues/1) and not the Pull Request.
Please post the changelog entry on the original GitHub issue (#1) and not the Pull Request.
@raamdev Done. Changelog entry moved to original GitHub issue #1.
Replace FontAwesome with WP Dashicons;
padding
withmargin
on Dashicon to adjust spacing so it's not too close to the text right next to it.dashicons-warning
for Error Alert Box,dashicons-flag
for Warning Alert Box, anddashicons-info
for Info Alert BoxSee: websharks/alert-box-shortcode#1