search

wpsharks / comet-cache

An advanced WordPress® caching plugin inspired by simplicity.
https://cometcache.com
GNU General Public License v3.0
75 stars 17 forks source link

Some Debug Notices Don't Check `is_html_xml_doc()`. #410

Open jaswrks opened 9 years ago

jaswrks commented 9 years ago

It has come to my attention that there's one particular case where Quick Cache and Quick Cache Pro are currently unable to check is_html_xml_doc() before appending debug notes. While it's not necessarily a bug, this can lead to confusion when it comes to AJAX calls that default to a text/html content type; yet treat the response as plain text.

In this case, the bug is actually with the implementation. However, I'd like to find ways to call upon is_html_xml_doc() in all cases. There's still one slipping through the cracks.

Referencing: https://github.com/websharks/quick-cache/blob/000000-dev/quick-cache/includes/advanced-cache.tpl.php#L975 Referencing: https://wordpress.org/support/topic/cache-warning?replies=5#post-6531292

raamdev commented 9 years ago

Thanks for the report! While it might not necessarily be a bug, I can see how it might be interpreted as one, so I'm going to mark this as a bug.