wpsharks / comet-cache

An advanced WordPress® caching plugin inspired by simplicity.
https://cometcache.com
GNU General Public License v3.0
75 stars 17 forks source link

Warning about lack of xml sitemap when the sitemap exists #615

Closed KTS915 closed 9 years ago

KTS915 commented 9 years ago

This relates to the new feature released and documented at Issue #555.

I tried the RC with this feature, using the Simple WP Sitemap plugin, and had no problems. I had the same flawless experience when I then installed the public version -- except on one site, where it claimed that there was no sitemap.xml, even though the sitemap plugin was already activated and my browser could locate the sitemap.

I thought that maybe that was just user error on my part -- after all, the other installs had worked fine -- but there is now also this report on the Zen Cache wordpress.org forum: https://wordpress.org/support/topic/sitemap-problem-15?replies=1

That user is using a different sitemap plugin from me, so it doesn't seem that that could be the cause.

This leads to two questions:

  1. Is Zen Cache now generating warnings when everything is in fact OK?
  2. Is there a way to tell whether (whatever the warning says) Zen Cache is making use of the sitemap.xml file?
jaswrks commented 9 years ago

@KTS915 Thanks for the report! :-)

Referencing: https://github.com/websharks/zencache-pro/blob/151105/src/includes/classes/AutoCache.php#L246-L258

This warning occurs whenever:

A quick review of the code that issues this warning doesn't show any problems so far as I can see, but I will keep my eyes open for more reports like this one. Please let us know if you encounter any others.

  1. Is there a way to tell whether (whatever the warning says) Zen Cache is making use of the sitemap.xml file?

If the warning goes away, or if you inspect the /wp-content/cache/zencache/cache/zc-auto-cache.log file and find that URLs from your /sitemap.xml file are in fact being cached, according to the log entries.

raamdev commented 9 years ago

except on one site, where it claimed that there was no sitemap.xml, even though the sitemap plugin was already activated and my browser could locate the sitemap.

@KTS915 Would it be possible to get the output of phpinfo() on that site so that we can review the PHP configuration? It sounds to me like there might be an issue with that server connecting to its own URL.

KTS915 commented 9 years ago

@raamdev,

I've installed the WordPress phpinfor{} plugin. There's an awful lot of info here! Which bit do you need? Just the PHP Variables?

raamdev commented 9 years ago

@KTS915 If you can copy/paste all of it into an "unlisted" http://pastebin.com and then paste the link on Slack (so it stays private), I should be able to find the bit(s) that I need.

raamdev commented 9 years ago

@KTS915 I just discovered an issue with the error reporting in that notice; see https://github.com/websharks/zencache/issues/616. The problem is that once you dismiss the notice, it will never reappear, even if the problem still exists. This was an oversight in the creation of that notice, so I opened https://github.com/websharks/zencache/issues/616 to resolve that in the next update.

For now, there really isn't any easy way of determining if ZenCache reports that your XML Sitemap is still unreachable, at least not without deleting the value of zencache_notices in your wp_options database table.

If you are able to reach your XML Sitemap in the browser and the wp-content/cache/zencache/zencache-auto-cache.log file shows that pages on your site are being visited by the Auto-Cache Engine, then there's likely nothing wrong and the initial notice that you dismissed was probably an anomaly.

In any case, we'll have this improved in the next ZenCache Pro release. :-)

I'm going to close this issue for now, but if you have any new information to report, please let me know and I'll reopen this.

rballengee commented 8 years ago

Hi, I stumbled on this thread this evening, frustrated and looking for answers. About a week ago, I first installed ZenCache, hoping it might provide a caching solution that wouldn't upend a WPMU membership plugin. It did, with some thinking, but it unfortunately has killed my sitemaps' compatibility with Google Webmasters Tools.

Although I didn't make a change in my sitemap plugin (XML Sitemap & Google News feeds), I now have a warning in GWT for my sitemaps it generates, saying, "Your Sitemap does not appear to be in a supported format." However, it validates using myriad tools, and a sitemap generated from xml-sitemaps.com passes muster. I tried a bunch of different sitemap plugins to see if a change might work, but it all boils down to ZenCache. I'm not sure what to do, but I don't want to have to go to the same site every time I post or do it manually.

I guess the nuclear option is to create a new database, only move over the crucial stuff and start over, but, again, I don't want to do that.

The help is much appreciated.

KTS915 commented 8 years ago

@rballengee,

Are you caching logged-in members?

rballengee commented 8 years ago

I'm not

On Thu, Nov 26, 2015 at 10:19 PM, KTS915 notifications@github.com wrote:

@rballengee https://github.com/rballengee,

Are you caching logged-in members?

— Reply to this email directly or view it on GitHub https://github.com/websharks/zencache/issues/615#issuecomment-160033796.

KTS915 commented 8 years ago

Hmm, OK. I am still wondering whether having protected pages is somehow relevant (perhaps because Google can't access all the pages in the sitemap).

rballengee commented 8 years ago

I'm starting to suspect the same. Went into GWT since, as you'd expect, I have a hike in Soft 404s, and had Google fetch some of the URLs, including the sitemap.

All return: Fatal error</b>: Call to a member function add_membership() on a non-object in <b>/home/thegol5/public_html/wp-content/plugins/membership/app/addon/searchindex/class-ms-addon-searchindex.php</b> on line <b>286

However, when I ask Google to render the page as a normal person would see it, then it shows it. So the thread here may have sent me in a wrong direction.

On Thu, Nov 26, 2015 at 10:37 PM, KTS915 notifications@github.com wrote:

Hmm, OK. I am still wondering whether having protected pages is somehow relevant (perhaps because Google can't access all the pages in the sitemap).

— Reply to this email directly or view it on GitHub https://github.com/websharks/zencache/issues/615#issuecomment-160034861.

theperfectwill commented 8 years ago

@jaswsinc @raamdev

I am building a new version of a client's site, but you can take a look at the live version that still has this issue, that would help?

The issue started after the latest Zencache or Yoast update. I'm not sure which.

I can still access and verify the xml sitemap is at it's location, but I still get the warning that Zencache couldn't find that file.

This is using the Pro version.

raamdev commented 8 years ago

@NoahjChampion If you look at the wp-content/cache/zencache/zencache-auto-cache.log file, does it look like the Auto-Cache Engine is working, i.e., like it's pre-caching the pages?

theperfectwill commented 8 years ago

@raamdev

Sort of...

Looking at the .log:

For the "/product/* page:

Lastly:

jaswrks commented 8 years ago

Just noting this related issue: https://github.com/websharks/zencache/issues/618

raamdev commented 8 years ago

ZenCache Pro v151220 has been released and includes changes worked on as part of this GitHub Issue. See the release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#615).