wpsharks / comet-cache

An advanced WordPress® caching plugin inspired by simplicity.
https://cometcache.com
GNU General Public License v3.0
75 stars 17 forks source link

Pro upgrade notice is not dismissed when upgrading via FTP #806

Closed raamdev closed 7 years ago

raamdev commented 8 years ago

If you upgrade Comet Cache Pro via FTP, the Dashboard notice that announces a new version is available does not get automatically dismissed.

2016-07-12_16-53-07

There needs to be a routine that dismisses any upgrade notice if the current version installed is detected as the latest version.

jaswrks commented 8 years ago

Estimate .25 days.

jaswrks commented 7 years ago

Related comment: https://github.com/websharks/comet-cache/issues/829#issuecomment-252807069

jaswrks commented 7 years ago

Next Release Changelog:

jaswrks commented 7 years ago

Noting also that these update notifications that are being cleared no longer exist in the current release of the software. The automatic clearing of these persistent notifications is to clear them on old installations of Comet Cache.

renzms commented 7 years ago

@jaswsinc

screen shot 2016-11-13 at 7 05 23 pm

Built from the current dev branch and ran phing -D project_version=160701 full-build-all to backdate, but no update available shows in the header. Is this the correct way to test this?

jaswrks commented 7 years ago

@renzms You'd need to actually install one of the older builds where that notification was posted to the Dashboard. The newer builds, like those from the dev branch, don't do this, even if you backdate the build. It's still from the newer source code that doesn't post that notice.

renzms commented 7 years ago

@jaswsinc

Thanks!

@raamdev

Confirmed working in Comet Cache v161116-RC / Pro

Tested using Comet Cache 160412 / Pro and upgraded via FTP using Comet Cache v161116-RC / Pro. Update notice is removed after uploading via FTP.

screen shot 2016-11-16 at 10 25 13 pm

raamdev commented 7 years ago

Comet Cache v161119 has been released and includes changes from this GitHub Issue. See the v161119 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#806).