search

wpsharks / comet-cache

An advanced WordPress® caching plugin inspired by simplicity.
https://cometcache.com
GNU General Public License v3.0
77 stars 18 forks source link

Comet Cache v161214-RC (Release Candidate) #858

Closed raamdev closed 7 years ago

raamdev commented 7 years ago

General Availability Target: December 16th, 2016

Downloads

Changelog

See also: Comet Cache v161214-RC Release Announcement

Reporting Issues / Feedback

Please report any issues or feedback related to this Release Candidate using this GitHub issue. Please post a comment below with details.

If you are reporting a UI-related issue, please include a screenshot.

If you are reporting a bug, please provide list of steps to reproduce and if the bug is related to an existing GitHub issue, please provide a link to that GitHub issue as well.

Reported Issues to Fix

None at this time.

raamdev commented 7 years ago

@jaswsinc TODO

Jason wrote in Slack:

Regarding mobile mode. Just an idea, but the current browser.version token is the full complete version (e.g., 1.2.12923923-alpha) and that's not very useful. In the future, or sometime between now and the official release, we should probably change browser.version so that it only contains the [major].[minor] version numbers. That way when this is used by others who need it, it's not just absolutely nuts to turn this on. Right now, it's fairly unreasonable to assume anyone could use that and actually make it work with any stability.

renzms commented 7 years ago

Confirmed Working

renzms commented 7 years ago

@raamdev

For the panels that use Watered Down REGEX and have external links, they correctly redirect and have the redirect links at http://cometcache.com/r/.

http://cometcache.com/r/watered-down-regex-syntax/ - https://cometcache.com/kb-article/watered-down-regex-syntax/

For the following, should we put them on a domain we own and redirect?

REQUEST_URI - https://gist.github.com/jaswsinc/338b6eb03a36c048c26f

HTTP_REFERER - http://php.net//manual/en/reserved.variables.server.php

HTTP_USER_AGENT - http://php.net//manual/en/reserved.variables.server.php

KTS915 commented 7 years ago

Using Firefox mobile on Android on my localhost test site running Linux Mint 17.3, I get the following message:

Array to string conversion in /var/www/html/blog/wp-content/plugins/comet-cache-pro/src/includes/traits/Shared/Conditional/Utils.php on line 156
raamdev commented 7 years ago

@KTS915 Thanks for the report!

@jaswsinc Here's line 156 reported above: https://github.com/websharks/comet-cache-pro/blob/161214-RC/src/includes/traits/Shared/ConditionalUtils.php#L156

Anything you're seeing there that might warrant holding up the release?

KTS915 commented 7 years ago

@raamdev @jaswsinc I am now getting this error message on Chrome as well. (Strangely, I wasn't getting it before.)

jaswrks commented 7 years ago

Taking a look at this now.

jaswrks commented 7 years ago

@KTS915 Thanks for reporting this.

Based on the iteration that error points to, I'd say the most likely cause of this is a rogue plugin. It's not possible to store an array in a cookie. Only a string or numeric value. So if the $_COOKIE superglobal contains a key holding an array, the only way I can see this happening is if another theme or plugin is forcing it to contain an array, at runtime.

@raamdev Having said that, we can add an is_string() check to this iteration instead of only typecasting it, just to avoid this error from occurring. I don't see this needing to hold up a release, but it's also a quick fix if you'd like to tweak it. In that iteration, if the value is not a string, we should just continue past it instead of trying to convert it.

KTS915 commented 7 years ago

@jaswsinc: Sadly, it doesn't appear to be a rogue plugin or custom theme. I've just tried both browsers on my Android phone on the same site, but with the 2015 theme and all plugins except CC deactivated. I also cleared the browser caches. I still get the same messages.

What seems strange to me is that this is not happening on my desktop PC with either browser.

raamdev commented 7 years ago

@KTS915 Have you tried clearing the browser cache on those mobile browsers, just in case the cookie(s) got corrupted somehow?

KTS915 commented 7 years ago

@raamdev : Yes, I did.

raamdev commented 7 years ago

Comet Cache v161221 has been released and includes changes from this GitHub Issue. See the v161221 announcement for further details.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#858).