search

wpsharks / comet-cache

An advanced WordPress® caching plugin inspired by simplicity.
https://cometcache.com
GNU General Public License v3.0
77 stars 18 forks source link

Bug: Firefox = Broken Textarea #866

Closed jaswrks closed 7 years ago

jaswrks commented 7 years ago

This is broken in the most recent version of Firefox.

2016-12-28_03-14-48

jaswrks commented 7 years ago

Referencing internal/private ticket: https://app.intercom.io/a/apps/zbpo3mkk/inbox/me@jaswsinc.com/conversations/7405306906

raamdev commented 7 years ago

This appears to be caused by the style="white-space:nowrap;" attribute on that textarea.

raamdev commented 7 years ago

Related Mozilla bug report: https://bugzilla.mozilla.org/show_bug.cgi?id=1137650

According to the spec, we should be using style="white-space:pre-wrap;", which preserves new lines, not nowrap, which collapses new lines.

raamdev commented 7 years ago

Confirmed that pre-wrap works as expected on Firefox Version 50.1.0 (macOS), Chrome Version 55.0.2883.95 (macOS), and Safari Version 10.0.2 (macOS).

jaswrks commented 7 years ago

Referencing: https://developer.mozilla.org/en-US/docs/Web/CSS/white-space ~ I agree with the above and that was my mistake. However, I think pre is even better than pre-wrap in this case. We don't ever want breaks to occur because much of Comet Cache is based on line-delimited configuration options.

renzms commented 7 years ago

Confirmed Working

Tested Using:

WordPress Version: 4.7.2 Current WordPress Theme: Twenty Seventeen version 1.1 Theme Author: the WordPress team - https://wordpress.org/ Theme URI: https://wordpress.org/themes/twentyseventeen/ Active Plugins: Comet Cache Comet Cache™ Pro v170201-RC PHP Version: 7.0.10-2+deb.sury.org~xenial+1 MySQL Version: 10.0.29-MariaDB-0ubuntu0.16.04.1

FireFox: 51.0.1

Tested by attempting to fill-in multiple CDN Hostnames from a Network installation and going to the next line by pressing Enter.

screen shot 2017-02-03 at 8 58 32 pm

raamdev commented 7 years ago

Comet Cache v170220 has been released and includes changes from this GitHub Issue. See the v170220 announcement for further details.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#866).