wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.
http://comment-mail.com
GNU General Public License v3.0
8 stars 3 forks source link

v160211-RC: Email template includes <em> tags in subject #232

Closed raamdev closed 8 years ago

raamdev commented 8 years ago

It looks like some of the email templates that were updated in https://github.com/websharks/comment-mail/issues/201 inadvertently had subject lines changed to include <em> tags. Email subject lines won't process HTML.


2016-02-12_09-46-52


I suggest we change the subject line to "Confirm your subscription: [Post TItle]" and get rid of quotes in the subject line altogether.

Also, the italic Post Title in the body of this email doesn't look right. If the Post Title appears on a line all by itself, it doesn't need to be italic or have double-quotes. Being on a line all by itself is emphasis enough.

raamdev commented 8 years ago

Italics here is also unnecessary, since the title is on a line by itself:

2016-02-12_09-59-10

raamdev commented 8 years ago

I've started working on this.

raamdev commented 8 years ago

@jaswsinc I'm looking at the various snippets used in the subject lines and my feeling is that the best way to make them look good and easily separate from the title of the post (because we have no idea what that may contain) would be to follow WordPress' lead and do what they do for WordPress.com subscriptions: Enclose the meta information in brackets.

[New Replies to Your Comment] How to Understand Life, Love and Yourself [New Comments] How to Understand Life, Love and Yourself [New Reply to Your Comment] How to Understand Life, Love and Yourself [New Reply to Comment ID #3523] How to Understand Life, Love and Yourself

The subscription confirmation email subject would be this:

Confirm subscription: How to Understand Life, Love and Yourself

If you don't have any major objections to this, I'm going to go ahead and update this.

raamdev commented 8 years ago

Fixed by #232 and websharks/comment-mail-pro#57

raamdev commented 8 years ago

Comment Mail v160213 has been released and includes changes from this GitHub Issue. See the release announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#232).