search

wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.
http://comment-mail.com
GNU General Public License v3.0
8 stars 3 forks source link

Bug: Plugin Links Overlapping #236

Closed jaswrks closed 8 years ago

jaswrks commented 8 years ago

Overview

The plugin-related links overlap other portions of the menu page whenever the logo is not shown.

Steps to Reproduce

2016-02-14_21-23-51

2016-02-14_21-23-24

raamdev commented 8 years ago

Yep, I was able to reproduce this too.

raamdev commented 8 years ago

@renzms Could you look into this?

renzms commented 8 years ago

Could you look into this?

@raamdev Sure!

renzms commented 8 years ago

@raamdev @jaswsinc

Changed the following in the CSS, before committing though I'd just like to share the screens.

Without the logo, did you want the options on the left near the dividing line, or more aligned to the top just like the options on the right?

menu-page .pmp-heading {
 padding-bottom: 3em;
 margin-bottom: 2em;
 position: relative;
 min-height: 80px;
}

.pmp-heading-links {
 float: left;
 clear: left;
}

With Logo screen shot 2016-03-05 at 12 54 21 am

Without Logo

screen shot 2016-03-05 at 12 54 32 am

raamdev commented 8 years ago

Hmm, I'm not sure why the Logo is missing in the Lite version... it should always show up there IMO.

raamdev commented 8 years ago

Also, it looks like those options get pushed down when a Dashboard notice (such as the "Upgrading from StCR" notice) appears:

2016-03-04_12-44-11

We need to make sure that gets fixed as part of this GitHub issue too.

renzms commented 8 years ago

@raamdev

Hmm, I'm not sure why the Logo is missing in the Lite version... it should always show up there IMO.

The screenshots I provided is the observed behaviour when the logo display is turned off/on in the administrative area when using Pro.

Also, it looks like those options get pushed down when a Dashboard notice (such as the "Upgrading from StCR" notice) appears:

This I have not tested yet, but maybe the changes I made to the CSS will stop even the notices from pushing it too far down the break line.

raamdev commented 8 years ago

maybe the changes I made to the CSS will stop even the notices from pushing it too far down the break line.

Can you test that?

The screenshots I provided is the observed behaviour when the logo display is turned off/on in the administrative area when using Pro.

Oh, I see. I did not even realize that was an option. Ha! The way you have the options in those screenshots looks perfect to me.

renzms commented 8 years ago

@raamdev

Can you test that?

I rolled back to ZenCache and updated some options to get some notifications up, then added my css changes:

screen shot 2016-03-05 at 11 07 26 pm

raamdev commented 8 years ago

What about installing StCR, adding a subscription, then installing Comment Mail so that the Upgrading from StCR message shows up? That's the more likely message for Comment Mail users to see, so I just want to make sure it works with that.

raamdev commented 8 years ago

Also, can you please submit a PR for this with whatever code you're testing these screenshots with?

renzms commented 8 years ago

What about installing StCR, adding a subscription, then installing Comment Mail so that the Upgrading from StCR message shows up? That's the more likely message for Comment Mail users to see, so I just want to make sure it works with that.

Sure, tested and still works like a charm. I'll submit a PR as well. Here you go:

screen shot 2016-03-05 at 11 22 08 pm

raamdev commented 8 years ago

Fixed via https://github.com/websharks/comment-mail-pro/issues/61.