Disable Browser Username/Password Autofill on Pro Updater page

wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.

http://comment-mail.com

GNU General Public License v3.0

8 stars 3 forks source link

Disable Browser Username/Password Autofill on Pro Updater page #274

Closed raamdev closed 8 years ago

raamdev commented 8 years ago

This issue was recently solved for Comet Cache. We need to apply the same fix to the Comment Mail Pro plugin updater. See https://github.com/websharks/comet-cache/issues/741#issuecomment-223008092.

It looks like we can use autocomplete="off" in the <form> tag and Firefox will obey that. Then we can use autocomplete="new-password" in the individual fields, and Chrome will obey that. Woohoo!

2016-06-03_18-58-24

renzms commented 8 years ago

@raamdev

While I was testing this before I made changes, I noticed the header going into the panel and overlapping screen shot 2016-06-07 at 9 57 08 pm

Is this happening in your install too?

raamdev commented 8 years ago

Is this happening in your install too?

Nope, I'm not seeing that. Did you double check that you have the latest from the dev branch? Also, try clearing your browser cache.

raamdev commented 8 years ago

Next Release Changelog:

Bug Fix (Pro): When Chrome or Firefox Autofill Username/Password was enabled, the Comment Mail Pro Updater fields would incorrectly be autofilled by the browser with invalid credentials. This has been fixed. Props @renzms. Issue #274.

raamdev commented 8 years ago

Comment Mail v160618 has been released and includes changes from this GitHub Issue. See the v160618 announcement for further details.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#274).