wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.
http://comment-mail.com
GNU General Public License v3.0
8 stars 3 forks source link

StCR plugin notification still displaying even after uninstalling #292

Closed kristineds closed 7 years ago

kristineds commented 8 years ago

If Subscribe to Comments Reloaded (StCR) was previously uninstalled on a site where Comment Mail Pro is freshly installed, it should gracefully handle the scenario by detecting that the StCR plugin is no longer part of the site.

As of now, the dev version (Comment Mail Pro v160618) doesn't handle this scenario properly and instead displays the plugin notification message even if the StCR plugin is already uninstalled from the site.

screen shot 2016-08-11 at 6 07 03 pm

Also, when Comment Mail Pro is first installed on a site, two plugin notification messages are displayed with links going to the same page, /wp-admin/admin.php?page=comment_mail. This might be confusing to site owners and it would be nice if only one of them is displayed.

screen shot 2016-08-11 at 6 32 31 pm screen shot 2016-08-11 at 6 32 36 pm

raamdev commented 7 years ago

@renzms Could you try to reproduce this with the latest version of Comment Mail to see if this issue is still valid?

jaswrks commented 7 years ago

I can confirm that this has been fixed. See this line, following work in https://github.com/websharks/comment-mail/issues/294

raamdev commented 7 years ago

@jaswsinc Thanks!