search

wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.
http://comment-mail.com
GNU General Public License v3.0
8 stars 3 forks source link

Comment Mail PHP7 Compatibility #298

Closed renzms closed 7 years ago

renzms commented 8 years ago

Using the PHP compatibility checker against Comment Mail Pro in WordPress yields the following results:

Comment Mail Pro

FILE: /wp-content/plugins/comment-mail-pro/src/vendor/lusitanian/oauth/src/OAuth/Common/Http/Uri/UriFactoryInterface.php
-------------------------------------------------------------------------------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------------------------------------------------------------------------------
 17 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4
-------------------------------------------------------------------------------------------------------------------------------------------------------

FILE: /wp-content/plugins/comment-mail-pro/src/vendor/lusitanian/oauth/src/OAuth/Common/Http/Uri/UriFactory.php
----------------------------------------------------------------------------------------------------------------------------------------------
FOUND 7 ERRORS AFFECTING 7 LINES
----------------------------------------------------------------------------------------------------------------------------------------------
  19 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4
  76 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4
  95 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4
 118 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4
 134 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4
 144 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4
 160 | ERROR | Parameter shadowing super global ($_server) causes fatal error since PHP 5.4
----------------------------------------------------------------------------------------------------------------------------------------------

See Jason's findings here:

The error in a Comment Mail library: "Parameter shadowing super global ($_server) causes fatal error since PHP 5.4", is worth taking a closer look at. I suspect this is a false-positive as well, but it won't hurt to dig deeper on this one and be sure. That's being triggered in a library dependency in Comment Mail and not in the Comment Mail codebase itself.

If you're looking for problems, you'd want to put your attention on the composer.json file and do a review of the external library dependencies that it has.

raamdev commented 8 years ago

Related: https://github.com/websharks/comment-mail/issues/272

raamdev commented 7 years ago

Closing this, as Comment Mail has now been whitelisted in the PHP Compatibility Checker plugin as compatible with PHP 7: https://wordpress.org/support/topic/false-positive-comment-mail/