Subscribe without commenting shows unapproved comments

[IvanRF]

I just saw something weird in my Subscriptions list and found this bug: Comments that were not yet approved are shown in the subscribe without commenting page (Add New Subscription).

I had a user subscribed to a comment that I did not approved 😄

[raamdev]

@IvanRF Thanks for the report! We'll get this tested soon.

[renzms]

@raamdev

Tested this under the following conditions:

• WordPress 4.6.1 running Twenty Sixteen theme with Comment Mail Pro Version 160818 / Comment Mail Version 160824 installed
• Dashboard → Settings → Discussion → Check Comment must be manually approved
• Logged in/registered user and unregistered user comments

When commenting on a post as either a registered/unregistered user, the comment will appear to the user as an unapproved comment awaiting moderation after submission of the comment.

Hitting reply to the unapproved comment will allow the same user to Subscribe without commenting to the comment.

They will then be taken to the Add a new subscription page, where they can view all comments, including the unapproved comments.

[IvanRF]

Also, without hitting Reply if another user enters the page and just selects Subscribe without commenting, he will see the unapproved comment too.

[renzms]

Also, without hitting Reply if another user enters the page and just selects Subscribe without commenting, he will see the unapproved comment too.

@raamdev

I can confirm this as well, subscribing without commenting allows anyone to view the whole comments list including unapproved comments.

[raamdev]

@renzms Thanks for testing! That confirms this is a bug that needs to be fixed.

---

@jaswsinc Bug is as follows: Unapproved comments should not appear in the list of comments to subscribe to when subscribing without commenting.

[jaswrks]

Copy that. Referencing this block. Estimate 1 day.

[jaswrks]

Next Release Changelog:

• Bug Fix: Exclude unapproved comments from the dropdown menu on the 'Subscribe Without Commenting' form. See also: issue #299 for further details.

[raamdev]

@renzms Could you please test a dev build to confirm that this issue has been resolved?

[renzms]

@raamdev / @jaswsinc

Hi Guys!

I can confirm that unapproved comments no longer appear in the Subscriptions list! 👍

---

However...

I have observed a new minor issue with the Comment list field on the Subscriptions page.

Expected Behavior:

• On posts that have an already approved Comment, the field appears with a dropdown menu.

Observed Behavior:

• On posts that have no comments at all, the field appears to have arrows for entering numerical values.

• The field also seems to accept manual numerical input

[raamdev]

@jaswsinc See above. ↑ Can we just show a message in place of the select box that says "This post has no comments." when there are no comments for the selected post?

[jaswrks]

Yes, that sounds like a good idea to me also. Please fork that into a new issue.

[raamdev]

Please fork that into a new issue.

Done. I don't think that issue warrants holding up the Comment Mail RC, so I'll leave that work for a future release milestone.

[renzms]

@raamdev

Other than the issue here about the numerical values: https://github.com/websharks/comment-mail/issues/310

Tested to make sure it doesn't show unapproved comments and it's working! 👍

[raamdev]

Comment Mail v161118 has been released and includes changes from this GitHub Issue. See the v161118 announcement for further details.

---

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#299).