wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.
http://comment-mail.com
GNU General Public License v3.0
8 stars 3 forks source link

Improve Accessibility for Screen Readers #304

Closed renzms closed 7 years ago

renzms commented 7 years ago

On the Manage Subscriptions or Subscribe page, there are drop downs. When selecting a post, and selecting a comment to subscribe to, a screen reader will read this as read only and goes into edit mode when it should remain in browse mode.

It would be nice if instead, we replace these drop downs with Combo Boxes or drop downs with aria-labels to let the user know when it is expanded or collapsed.


Referencing Internal Ticket:

https://websharks.zendesk.com/agent/tickets/14702

alexstine commented 7 years ago

+1. Really looking for a solution, I am willing to test and work with everyone to get this fixed.

Thanks.

alexstine commented 7 years ago

@raamdev, This is more general, but the plugin has lots of FontAwesome icons scattered about through various parts of the plugin. Think in the future aria-hidden="true" could be added so screen readers know to ignore them? Haven't tried, but maybe that would help us on the drop downs by telling the screen reader to ignore the "read only" part, maybe that is a temporary solution.

jaswrks commented 7 years ago

New option coming soon...

See: Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings

2016-12-01_23-47-12

jaswrks commented 7 years ago

Referencing Chrome Extension for testing purposes: https://chrome.google.com/webstore/detail/chromevox/kgejglhpjiefppelpmljglcjbhoiplfn

jaswrks commented 7 years ago

Next Release Changelog:

jaswrks commented 7 years ago

Referencing accessibility issues with the jQuery Chosen extension that powers our enhanced select option menus in Comment Mail. Disabling jQuery Chosen (i.e., select menu option enhancements in Comment Mail) will restore accessibility until such time as this jQuery extension is enhanced. See: https://github.com/harvesthq/chosen/issues/264

alexstine commented 7 years ago

@jaswsinc, is this option available yet? To disable the special jQuery drop downs? Would really like to see some push to get this out fast since there are laws that say sites should be accessible.

If it's not an option, are there any quick patch work around?

Thanks.

jaswrks commented 7 years ago

@tech55541 This is going to get pushed out really soon, yes.

In the meantime, if you'd like to test it even earlier you can signup for our beta mailing list here: http://comment-mail.com/beta-testers/ and you'll get an early copy of the release candidate via email.

jaswrks commented 7 years ago

@tech55541 Here is an even earlier copy that is available for testing. This is an unstable bleeding edge copy of the latest revisions that make this possible. Please report any problems. Thanks!

Download link: https://cdn.wpsharks.com/software/bleeding-edge/comment-mail-pro/10bafd51ac92c9e.zip

alexstine commented 7 years ago

Will test on my staging site and let you know @jaswsinc.

alexstine commented 7 years ago

Hello again @jaswsinc,

I really haven't tested functionality overall yet, but the accessibility fix works. Please do include this in the documentation or make the accessibility option default. This jQuery drop downs in my opinion should not be enabled by default, it would not do the blind community any favors if the person setting this plugin up overlooks this setting.

I understand we're in the early stages, thanks for taking such swift action here. :)

renzms commented 7 years ago

@jaswsinc @raamdev

Confirmed as working in latest bleeding edge version of Comment Mail Pro

Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings → Select Menu Options: Enhance? → No

screen shot 2016-12-09 at 7 20 13 pm

screen shot 2016-12-09 at 7 08 12 pm screen shot 2016-12-09 at 7 07 33 pm

The dropdown selectors are not enhanced by jQuery and allow for better accessibility for readers.


Default View with jQuery enhancements

Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings → Select Menu Options: Enhance? → Yes screen shot 2016-12-09 at 7 19 09 pm screen shot 2016-12-09 at 7 18 48 pm

raamdev commented 7 years ago

Comment Mail v161213 has been released and includes changes from this GitHub Issue. See the v161213 announcement for further details.


This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#304).