Closed renzms closed 7 years ago
+1. Really looking for a solution, I am willing to test and work with everyone to get this fixed.
Thanks.
@raamdev, This is more general, but the plugin has lots of FontAwesome icons scattered about through various parts of the plugin. Think in the future
aria-hidden="true"
could be added so screen readers know to ignore them? Haven't tried, but maybe that would help us on the drop downs by telling the screen reader to ignore the "read only" part, maybe that is a temporary solution.
New option coming soon...
See: Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings
Referencing Chrome Extension for testing purposes: https://chrome.google.com/webstore/detail/chromevox/kgejglhpjiefppelpmljglcjbhoiplfn
Next Release Changelog:
Accessibility: This release improves screen reader accessibility by adding aria-hidden="true"
to all FontAwesome icons. See Issue #304.
Accessibility: This release improves screen reader accessibility by offering a new setting that allows a site owner to enable or disable select menu option enhancement via jQuery. Disabling select menu option enhancement has the benefit of improving accessibility for screen readers whenever accessibility is of more concern than presentation. See: Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings. See also Issue #304.
Referencing accessibility issues with the jQuery Chosen extension that powers our enhanced select option menus in Comment Mail. Disabling jQuery Chosen (i.e., select menu option enhancements in Comment Mail) will restore accessibility until such time as this jQuery extension is enhanced. See: https://github.com/harvesthq/chosen/issues/264
@jaswsinc, is this option available yet? To disable the special jQuery drop downs? Would really like to see some push to get this out fast since there are laws that say sites should be accessible.
If it's not an option, are there any quick patch work around?
Thanks.
@tech55541 This is going to get pushed out really soon, yes.
In the meantime, if you'd like to test it even earlier you can signup for our beta mailing list here: http://comment-mail.com/beta-testers/ and you'll get an early copy of the release candidate via email.
@tech55541 Here is an even earlier copy that is available for testing. This is an unstable bleeding edge copy of the latest revisions that make this possible. Please report any problems. Thanks!
Download link: https://cdn.wpsharks.com/software/bleeding-edge/comment-mail-pro/10bafd51ac92c9e.zip
Will test on my staging site and let you know @jaswsinc.
Hello again @jaswsinc,
I really haven't tested functionality overall yet, but the accessibility fix works. Please do include this in the documentation or make the accessibility option default. This jQuery drop downs in my opinion should not be enabled by default, it would not do the blind community any favors if the person setting this plugin up overlooks this setting.
I understand we're in the early stages, thanks for taking such swift action here. :)
@jaswsinc @raamdev
Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings → Select Menu Options: Enhance? → No
The dropdown selectors are not enhanced by jQuery and allow for better accessibility for readers.
Dashboard → Comment Mail → Config Options → Misc. UI-Related Settings → Select Menu Options: Enhance? → Yes
Comment Mail v161213 has been released and includes changes from this GitHub Issue. See the v161213 announcement for further details.
This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#304).
On the Manage Subscriptions or Subscribe page, there are drop downs. When selecting a post, and selecting a comment to subscribe to, a screen reader will read this as read only and goes into edit mode when it should remain in browse mode.
It would be nice if instead, we replace these drop downs with Combo Boxes or drop downs with aria-labels to let the user know when it is expanded or collapsed.
Referencing Internal Ticket:
https://websharks.zendesk.com/agent/tickets/14702