wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.
http://comment-mail.com
GNU General Public License v3.0
8 stars 3 forks source link

Feature Request: Extend the Manage my Subscriptions feature #307

Closed renzms closed 7 years ago

renzms commented 7 years ago

It would be nice to extend the features of the manage my subscriptions link and shows the subscriptions for the logged in user.

screen shot 2016-10-29 at 8 48 33 pm

Some customizable options such as the following:

Missing subscription key; unable to display summary.

Referencing internal ticket: https://websharks.zendesk.com/agent/tickets/14763

raamdev commented 7 years ago

@renzms writes...

If the visitor does not have a subscription to any comment, present the user on this page an option to subscribe to available pages/posts and collect their email instead of showing the error prompt: Missing subscription key; unable to display summary.

Can you provide me with a list of steps to reproduce this behavior?

renzms commented 7 years ago

Can you provide me with a list of steps to reproduce this behavior?

Sure, it doesn't happen on a normal workflow but in this case the admin user wanted a direct link available via menu to the subscriptions page.

raamdev commented 7 years ago

when visiting this link while not logged-in

Does that link appear anywhere when not logged-in? It shouldn't, unless you've previously subscribed to a comment, which sets a cookie in your browser that then makes the link appear. So if the 'manage my subscriptions' link ever appears on the comment form of a site, the user should be able to click it and view their subscriptions. It should never appear unless you actually have a subscription.

renzms commented 7 years ago

It should never appear unless you actually have a subscription.

Right, customer wanted to link to a subscriptions page regardless if their visitors had previous comments and were not logged-in visitors. So they tried to use the link to go directly to the page and try to collect subscriptions without commenting in that way.

raamdev commented 7 years ago

@renzms Right, that's the expected behavior. If the user does not have any subscriptions, we don't have anything to show them, so a link to their list of non-existent subscriptions is not shown. I don't understand why you'd want to show them the My Subscriptions page if there's nothing to show them in the first place, hence my confusion about this feature request...

renzms commented 7 years ago

I don't understand why you'd want to show them the My Subscriptions page if there's nothing to show them in the first place, hence my confusion about this feature request...

@raamdev

In the original email the customer wrote in to request a direct page or link to the My Subscriptions Page, (the main request to extend the features of my subscription page) so any visitor could go to their "Subscriptions". If in the case, they didn't have any subscriptions, then the additional request was to allow them to view possible posts to subscribe to and collect their email without being logged in.

We can omit this part of the request then, as this is just an observed behavior by the customer when trying to link directly to the My Subscriptions page:

If the visitor does not have a subscription to any comment, present the user on this page an option to subscribe to available pages/posts and collect their email instead of showing the error prompt:

Missing subscription key; unable to display summary.

If the feature request is just to extend the capabilities of the My Subscriptions page to a shortcode or template then they would not encounter the above error for what they are trying to attempt; which is: collect emails and directly link to the Subscriptions page.

raamdev commented 7 years ago

If in the case, they didn't have any subscriptions, then the additional request was to allow them to view possible posts to subscribe to and collect their email without being logged in.

So, an Add Subscription page would be shown if they did not have any subscriptions? We toyed with that idea awhile back and decided against it, due to UX concerns. (How would someone know what post they want to subscribe to by selecting it from a drop-down box? They'd most likely visit the post first, then subscribe, in which case the existing "Subscribe without Commenting" link should work fine.)

extend the capabilities of the My Subscriptions page to a shortcode

I like the idea of a shortcode that could be inserted on a page to list a users subscriptions, that way a site owner could create such a page on their site using their site theme and make it look like it's part of their site (as opposed to having a custom Comment Mail-specific page for showing the subscriptions). If you could open a separate GitHub issue for that, that would be great ("Feature Request: Shortcode for My Subscriptions")

renzms commented 7 years ago

@raamdev

They'd most likely visit the post first, then subscribe, in which case the existing "Subscribe without Commenting" link should work fine.)

Agreed, this would probably work better in most cases.

If you could open a separate GitHub issue for that, that would be great ("Feature Request: Shortcode for My Subscriptions")

Cool, created new issue for that request. See: Feature Request: Shortcode for My Subscriptions

raamdev commented 7 years ago

Cool, thanks. I'll go ahead and close this issue then in favor of the one you opened.