StCR conflict detection no longer working

wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.

http://comment-mail.com

GNU General Public License v3.0

8 stars 3 forks source link

StCR conflict detection no longer working #315

Closed raamdev closed 7 years ago

raamdev commented 7 years ago

The conflict detection for Subscribe to Comments Reloaded is no longer working. When both StCR and Comment Mail are active, there is no Dashboard notice indicating that both plugins should not be enabled at the same time.

Steps to reproduce

Install Comment Mail >= v161110-RC and StCR v160915+
Activate and enable both plugins

Observed Behavior

No Dashboard messages appear.

Expected Behavior

A Dashboard notice should warn me that StCR and Comment Mail should not be enabled at the same time.

jaswrks commented 7 years ago

Next Release Changelog:

Bug Fix: The conflict check for 'Subscribe to Comments Reloaded' was not working in the previous release; i.e., if you attempt to activate both Comment Mail and the 'Subscribe to Comments Reloaded' plugin at the same, this should result in a Dashboard warning. Fixed in this release. See Issue #315.

jaswrks commented 7 years ago

Noting that this particular conflict detection never existed prior. However, it is now.

raamdev commented 7 years ago

Noting that this particular conflict detection never existed prior. However, it is now.

Hmm, that's very odd. I'm almost certain I remember seeing a Comment Mail message telling me that StCR and Comment Mail shouldn't be active at the same time... maybe I imagined it!

jaswrks commented 7 years ago

You might be right. If it was, I just don't remember it. Whenever I reviewed the codebase this time around it was not in there at all. That's what I should have said; i.e., I didn't fix anything. I had to add this in because it wasn't there at all.

renzms commented 7 years ago

@jaswsinc @raamdev

Confirmed Working

Prompt appears and does not activate Comment Mail if StCR is present.

screen shot 2016-12-13 at 3 55 32 pm

raamdev commented 7 years ago

Comment Mail v161213 has been released and includes changes from this GitHub Issue. See the v161213 announcement for further details.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#315).