wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.
http://comment-mail.com
GNU General Public License v3.0
8 stars 3 forks source link

Remove translation functions from exception messages #316

Closed raamdev closed 7 years ago

raamdev commented 7 years ago

PHP exception messages should not pass through __() translation functions, as it doesn't make sense to translate those messages (and translators won't understand what the string means, unless they're also a programmer). For example, see this line:

throw new \exception(sprintf(__('Refused to unset overload property: `%1$s`.', 'comment-mail'), $property));

We need to go through the codebase and strip out the translation functions from these exceptions.