search

wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.
http://comment-mail.com
GNU General Public License v3.0
8 stars 3 forks source link

MailChimp Integration: Empty API Key field autofills with password from browser #319

Closed raamdev closed 7 years ago

raamdev commented 7 years ago

If you have a password saved in your browser autofill, saving the Comment Mail options with MailChimp Integration enabled but the MailChimp API Key field empty, you can end up with a browser-filled password in the field:

2016-11-17_20-22-51

We dealt with this same issue in Comet Cache recently; see https://github.com/websharks/comet-cache/issues/741.

The fix that covers both Firefox and Chrome seems to be the following:

It looks like we can use autocomplete="off" in the <form> tag and Firefox will obey that. Then we can use autocomplete="new-password" in the individual fields, and Chrome will obey that

jaswrks commented 7 years ago

Next Release Changelog:

renzms commented 7 years ago

@jaswsinc @raamdev

Confirmed Working

screen shot 2016-12-13 at 3 24 09 pm

The MailChimp Integration fields do not autocomplete. 👍

raamdev commented 7 years ago

Comment Mail v161213 has been released and includes changes from this GitHub Issue. See the v161213 announcement for further details.

This issue will now be locked to further updates. If you have something to add related to this GitHub Issue, please open a new GitHub Issue and reference this one (#319)