search

wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.
http://comment-mail.com
GNU General Public License v3.0
8 stars 3 forks source link

Default storage engine ignored for some tables #331

Open mundschenk-at opened 7 years ago

mundschenk-at commented 7 years ago

I've noticed that while the <siteprefix>_comment_mail_queue table was created with the default storage engine (InnoDB - really XtraDB), three other tables (<siteprefix>_comment_mail_queue_event_log, <siteprefix>_comment_mail_sub_event_log and <siteprefix>_comment_mail_subs) where created with the outdated MyISAM storage engine.

raamdev commented 7 years ago

@mundschenk-at Only MySQL v5.6.4+ supports fulltext indexes with the InnoDB engine (the tables you mentioned use fulltext indexes). If you're not running MySQL v5.6.4+, we fall back on MyISAM for any table that includes a fulltext index.

See: https://github.com/websharks/comment-mail-pro/blob/161213/src/includes/classes/UtilsDb.php#L128-L142

mundschenk-at commented 7 years ago

I am running MariaDB 10.1, which does support FULLTEXT indices on InnoDB/XtraDB tables.

raamdev commented 7 years ago

@mundschenk-at Ah, I see. It sounds like we need to improve the Comment Mail fulltextCompat() function to include a check for MariaDB, which "is an enhanced, drop-in replacement for MySQL."

I'll reopen this and mark it as a bug. Thank you again for the report!

jaswrks commented 7 years ago

@mundschenk-at Is it possible that you're running on a Windows server?

jaswrks commented 7 years ago

I ask because I run MariaDB also, and I have noticed that WordPress incorrectly detects the version number for MariaDB on Windows servers. The version that WordPress sees begins with the version of the PHP driver for MySQL, not with the MariaDB version.

mundschenk-at commented 7 years ago

No, that's on FreeBSD.

jaswrks commented 7 years ago

Very good then. Thanks for the follow-up :-) Back to testing then. Not sure what's going on here exactly.