search

wpsharks / comment-mail

A WordPress plugin enabling email subscriptions for comments.
http://comment-mail.com
GNU General Public License v3.0
8 stars 3 forks source link

eval() required, but not used anywhere #333

Closed raamdev closed 7 years ago

raamdev commented 7 years ago

In v161118 we removed the use of eval() when parsing templates, however we're still requiring that function to be available, which is problomatic for sites that disable eval() for security purposes.

I did a quick search through the codebase and I'm not seeing anywhere that eval() is currently being used, so this should be removed as a requirement for the next update.

raamdev commented 7 years ago

This ☝️ was actually incorrect. eval() is still used in many places throughout the codebase for parsing customized templates and for making shortcodes in Simple templates possible.

I'm still reconsidering how we can simplify the codebase to reduce dependency on eval(), but I'm going to close this issue for now and open a separate one when I make a decision on a way forward.