search

wpsharks / html-compressor

HTML Compressor. Combines and compresses CSS/JS/HTML code.
https://websharks.github.io/html-compressor/
GNU General Public License v3.0
38 stars 9 forks source link

CSS references inside complex conditional comments should be excluded #35

Closed joeldbirch closed 10 years ago

joeldbirch commented 10 years ago

From the documentation it is clear that CSS files should be excluded when inside conditional comments. However, the following conditional breaks this. I'm using this to serve only IE9+ (and other browsers) a CSS file with media queries.

<!--[if (gte IE 9)|(gt IEMobile 7)|!(IE)]><!--><link rel="stylesheet" href="modern.css"><!--<![endif]-->

Love your work, by the way! Joel.

jaswrks commented 10 years ago

Hey, thanks for pointing this out! Adding this to my list. Referencing: http://css-tricks.com/how-to-create-an-ie-only-stylesheet/ See also: http://msdn.microsoft.com/en-us/library/ms537512(v=vs.85).aspx

joeldbirch commented 10 years ago

Thanks for the quick response! I'm so excited that my favourite plugin (Quick Cache) can now also replace wp-minify, which I have been spending countless hours maintaining on life-support in recent years!

jaswrks commented 10 years ago

Thanks for the quick response! I'm so excited that my favourite plugin (Quick Cache) can now also replace wp-minify

Very welcome! Me too :-) Same here.

jaswrks commented 10 years ago

This has been fixed in the development copy. It will go out in a future release of Quick Cache Pro.

If you'd like to use the latest version of the HTML Compressor in the current copy of Quick Cache Pro, you can grab the dev branch for the HTML Compressor and replace: /wp-content/plugins/quick-cache-pro/submodules/htmlc with the latest copy.

jaswrks commented 10 years ago

cc: @raamdev (QCP lead developer) ~ This fix will make it into the next official release of the HTML Compressor. I have a couple other issues I'd like to resolve before that happens, but I just wanted to give you a heads up.

joeldbirch commented 10 years ago

Amazing! Really appreciate this <3